Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fn encoding_mut() to Scene. #701

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add fn encoding_mut() to Scene. #701

merged 2 commits into from
Sep 26, 2024

Conversation

timtom-dev
Copy link
Contributor

This is a useful escape hatch to implement things not supported by the standard API.

@timtom-dev
Add fn encoding_mut() to Scene.
e1b4b75 
This is a useful escape hatch to implement things not supported by the standard API.
DJMcNab
DJMcNab approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this API is worth having, but we should discourage its use where possible.

vello/src/scene.rs Show resolved Hide resolved
@DJMcNab DJMcNab added this pull request to the merge queue Sep 26, 2024
Merged via the queue into linebender:main with commit ddcfcba Sep 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtom-dev @DJMcNab